Re: A Typo in regress/sql/privileges.sql

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tatsuro Yamada <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A Typo in regress/sql/privileges.sql
Date: 2015-12-18 18:57:51
Message-ID: 20151218185751.GD28035@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-12-18 13:50:34 -0500, Robert Haas wrote:
> On Wed, Dec 16, 2015 at 11:51 PM, Tatsuro Yamada
> <yamada(dot)tatsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> > I found typos in privileges.sql and privileges.out
> > Please find attached a patch.
>
> Thanks, good catch. But even aside from this particular issue, isn't
> that comment in need of a little more love? An inference means a
> deduction, or something you can figure out from something else. ON
> CONFLICT (four) is not an inference.

It's the index(es) that are inferred, from the ON(columns) and the ON
CONFLICT's WHERE clause. If we want to get rid of that terminology we'd
need to start elsewhere, and it'd be a bigger patch.

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2015-12-18 19:04:10 Re: Refactoring speculative insertion with unique indexes a little
Previous Message Peter Geoghegan 2015-12-18 18:55:21 Re: Using quicksort for every external sort run