| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixing warnings in back branches? |
| Date: | 2015-12-15 12:59:25 |
| Message-ID: | 20151215125925.GF17724@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-12-14 11:00:32 -0500, Robert Haas wrote:
> On Mon, Dec 14, 2015 at 10:06 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > to compile 9.1 without warnings. -Wincompatible-pointer-types is quite
> > useful to detect problems. The rest indeed is pretty 'Meh'.
>
> IIUC, the main thing that causes incompatible pointer type warnings on
> 9.1 is the conflation of FILE with gzFile in pg_dump and
> pg_basebackup.
Right.
> Not sure exactly which commits fixed that offhand.
d923125b77c5d698bb8107a533a21627582baa43 , but that doesn't fix the
'files' output format, which was removed in
19f45565f581ce605956c29586bfd277f6012eec
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-12-15 13:13:06 | Re: Fixing warnings in back branches? |
| Previous Message | Andres Freund | 2015-12-15 12:51:43 | Re: [PATCH] Logical decoding support for sequence advances |