From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixing warnings in back branches? |
Date: | 2015-12-14 15:06:58 |
Message-ID: | 20151214150658.GA13573@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2015-12-14 09:43:07 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2015-12-14 10:55:05 +0000, Greg Stark wrote:
> >> Perhaps just adding some -Wno-* flags would make more sense than
> >> changing code and possibly introducing bugs.
>
> > I think that's a case-by-case decision. Just verbatimly backpatching
> > something that stewed in master for a year or two seems fine. That's imo
> > often preferrable because often it's just that existing warning
> > categories grew more "vigilant", or however you want to describe it. So
> > if you disable those, you also remove coverage...
>
> Meh. If we thought that anything like that was an actual bug, we should
> have back-patched the fix when removing the warning in HEAD. So I would
> expect that all remaining warnings are just compiler nannyism, and thus
> that fixing them is more likely to introduce bugs than do anything very
> useful.
I'm more concerned about removing warnings that help detect problems
when backpatching. Right now I need
-Wno-incompatible-pointer-types \
-Wno-type-limits \
-Wno-unused-but-set-variable \
-Wno-empty-body \
-Wno-address
to compile 9.1 without warnings. -Wincompatible-pointer-types is quite
useful to detect problems. The rest indeed is pretty 'Meh'.
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-12-14 15:21:38 | Re: [COMMITTERS] pgsql: pg_rewind: Don't error if the two clusters are already on the sa |
Previous Message | Tom Lane | 2015-12-14 14:43:07 | Re: Fixing warnings in back branches? |