Re: pg_hba_lookup function to get all matching pg_hba.conf entries

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_hba_lookup function to get all matching pg_hba.conf entries
Date: 2015-12-04 16:16:15
Message-ID: 20151204161615.GY2763@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Haribabu Kommi wrote:

> The trace messages that are going to print doesn't come to client until the
> connection gets successful. The traces may not useful for the clients
> to find out
> why the connection is failing. But it may be useful for administrators.
> How about the attached patch?
>
> [kommih(at)localhost bin]$ ./psql postgres -h ::1
> psql (9.6devel)
> Type "help" for help.
>
> postgres=#
>
> ServerLog:
> NOTICE: Skipped 84 pg_hba line, because of host connection type.
> NOTICE: Skipped 86 pg_hba line, because of non matching IP.

That's going to be way too noisy. Some applications open dozens of
connections per second -- imagine a dozen NOTICEs per each connection
established. It's going to fill any disk you install as the server log
partition ...

I can imagine worse nightmares, but this one's a pretty ugly one.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2015-12-04 16:21:16 Re: Freeze avoidance of very large table.
Previous Message Alvaro Herrera 2015-12-04 16:11:36 Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.