Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Amir Rohan <amir(dot)rohan(at)zoho(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>,Noah Misch <noah(at)leadboat(dot)com>,Andres Freund <andres(at)2ndquadrant(dot)com>,PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>,Greg Smith <gsmith(at)gregsmith(dot)com>
Subject: Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.
Date: 2015-11-28 15:13:58
Message-ID: 20151128151358.GH4320@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:
> On Sat, Nov 28, 2015 at 7:53 AM, Alvaro Herrera wrote:

> > Hmm. I just noticed RewindTest sets $ENV{PGDATABASE} outside BEGIN. Not
> > sure what to think of that. Could instead pass the database name in
> > $node->getConnStr() calls, like run_pg_rewind() is already doing.
>
> Yes, let's remove that and pass the database name to getConnStr().

Ok.

> A separate issue, but as long as we are working on this set of tests:
> I have noticed that config_default.pl is missing the flag tap_tests in
> its list. See the patch attached. Could you apply that as well and
> backpatch?

> I have as well noticed that RewindTest.pm is missing "1;" on its last
> line. When this is loaded this would lead to compilation errors.

Sure.

> > I tried all the t/ tests we have and all of them pass for me. If I'm
> > able, I will push this on my Sunday late evening, so that I can fix
> > whatever gets red on Monday first thing ...
>
> I have done as well additional tests on Windows and this patch is
> showing a green status.

Great.

Here's your recovery test patch rebased, for your (and others'!)
perusal. It passes for me. (Test 003 is unchanged.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0002.patch text/x-diff 20.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Janes 2015-11-28 20:17:25 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Michael Paquier 2015-11-28 12:12:44 Re: COPY (INSERT/UPDATE/DELETE .. RETURNING ..)