| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amir Rohan <amir(dot)rohan(at)zoho(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <gsmith(at)gregsmith(dot)com> |
| Subject: | Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc. |
| Date: | 2015-11-19 02:39:30 |
| Message-ID: | 20151119023930.GA1434517@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2015 at 01:21:45PM -0200, Alvaro Herrera wrote:
> In my days of Perl, it was starting to become frowned upon to call
> subroutines without parenthesizing arguments. Is that no longer the
> case?
I've not witnessed those frowns.
> Because I notice there are many places in this patch and pre-
> existing that call psql with an argument list without parens. And it's
> a bit odd because I couldn't find any other subroutine that we're using
> in that way.
TestLib.pm has unparenthesized calls to "standard_initdb", "start" and "run".
070_dropuser.pl has such calls to "start_test_server" and "psql".
> In 005_replay_delay there's a 2s delay configured; then we test whether
> something is replayed in 1s. I hate tests that run for a long time, but
> is 2s good enough considering that some of our test animals in buildfarm
> are really slow?
That test will be unreliable, agreed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marko Tiikkaja | 2015-11-19 02:58:35 | Add numeric_trim(numeric) |
| Previous Message | Marko Tiikkaja | 2015-11-19 02:27:41 | Add scale(numeric) |