| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Cleanup commit timestamp module activaction, again |
| Date: | 2015-10-28 02:06:48 |
| Message-ID: | 20151028020648.GJ240637@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> > Tom Lane wrote:
> >> I think it's just failure to update an expected-file, but will leave it
> >> to Alvaro.
>
> > I don't understand. It passed make check fine for me on both branches.
> > Will fix in a jiffy.
>
> There are two variant expected files for that module --- did you fix
> both?
Yeah, this was the problem: make installcheck almost always exercises
the case with the setting disabled, which make check doesn't test.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-10-28 10:59:58 | pgsql: Fix incorrect message in ATWrongRelkindError. |
| Previous Message | Alvaro Herrera | 2015-10-28 02:04:34 | pgsql: Fix secondary expected output for commit_ts test |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haribabu Kommi | 2015-10-28 03:53:19 | Re: BUG #13741: vacuumdb does not accept valid password |
| Previous Message | Tom Lane | 2015-10-28 01:52:49 | Re: [COMMITTERS] pgsql: Cleanup commit timestamp module activaction, again |