| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Making tab-complete.c easier to maintain |
| Date: | 2015-10-23 17:50:58 |
| Message-ID: | 20151023175058.GA3391@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Janes wrote:
> For the bigger picture, I don't think we should not apply this patch simply
> because there is something even better we might theoretically do at some
> point in the future.
Agreed.
> Having used it a little bit, I do agree with Robert
> that it is not a gigantic improvement over the current situation, as the
> code it replaces is largely mechanical boilerplate. But I think it is
> enough of an improvement that we should go ahead with it.
To me this patch sounds much like 2eafcf68d563df8a1db80a. You could say
that what was replaced was "largely mechanical", but it was so much
easier to make mistakes with the original coding that it's not funny.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-10-23 18:33:34 | Re: [DESIGN] ParallelAppend |
| Previous Message | Jeff Janes | 2015-10-23 17:19:35 | Re: Making tab-complete.c easier to maintain |