| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, Bernd Helmle <mailings(at)oopsware(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Duplicated assignment of slot_name in walsender.c |
| Date: | 2015-10-21 21:53:23 |
| Message-ID: | 20151021215323.GE3391@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> On 2015-10-21 17:21:25 -0300, Alvaro Herrera wrote:
> > I think the first assignment is also pointless -- I mean can't we just
> > use MyReplicationSlot->data.name in both places where slot_name is used?
>
> Makes the lines a bit long. strlen(NameStr(MyReplicationSlot->data.name)) ...
Meh. Assign the strlen somewhere?
> > In the same routine, it seems wasteful to be doing strlen() twice for
> > every string sent over the wire.
>
> That seems fairly insignificant. For one this is a rather infrequent and
> expensive operation,
OK, I can buy that.
> for another every decent compiler can optimize those away. Note that
> those duplicate strlen() calls are there in a lot of places in
> walsender.c
It can? Tom has repeatedly argue the opposite, in the past.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-10-21 22:36:16 | Re: Duplicated assignment of slot_name in walsender.c |
| Previous Message | Andres Freund | 2015-10-21 21:36:26 | Re: pg_recvlogical fixes |