Re: 9.3.9 and pg_multixact corruption

From: Noah Misch <noah(at)leadboat(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andreas Seltenreich <andreas(dot)seltenreich(at)credativ(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Bernd Helmle <bernd(at)oopsware(dot)de>
Subject: Re: 9.3.9 and pg_multixact corruption
Date: 2015-10-04 06:33:35
Message-ID: 20151004063335.GA4129520@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 28, 2015 at 11:10:52AM -0400, Robert Haas wrote:
> On Fri, Sep 25, 2015 at 3:41 AM, Andreas Seltenreich <andreas(dot)seltenreich(at)credativ(dot)de> wrote:
> > OTOH, a unit test for multixact.c that exercises the code including
> > wraparounds sounds like a desirable thing regardless of the fact that it
> > could have caught this miscompilation earlier than 6 months into
> > production.
>
> Definitely.

+1. Catching compiler bugs is an important role of "make check". That suite
has a notable gap if it passes despite a compiler bug ruining the binary.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Charles Clavadetscher 2015-10-04 06:40:40 Re: Odd query execution behavior with extended protocol
Previous Message Peter Geoghegan 2015-10-04 06:21:05 SortSupport for UUID type