Re: perlcritic

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: perlcritic
Date: 2015-10-03 13:53:30
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2015-08-31 23:57:25 -0400, Peter Eisentraut wrote:
> We now have 80+ Perl files in our tree, and it's growing. Some of those
> files were originally written for Perl 4, and the coding styles and
> quality are quite, uh, divergent. So I figured it's time to clean up
> that code a bit. I ran perlcritic over the tree and cleaned up all the
> warnings at level 5 (the default, least severe).

As far as I can see we haven't really come to any conclusion in this

Peter, where do you want to go from here? As this patch has been in
waiting-for-author for a month, I'm marking it as


Andres Freund

In response to

  • perlcritic at 2015-09-01 03:57:25 from Peter Eisentraut

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2015-10-03 13:57:24 Re: Unicode mapping scripts cleanup
Previous Message Michael Paquier 2015-10-03 13:47:33 Re: In-core regression tests for replication, cascading, archiving, PITR, etc.