Re: track_commit_timestamp and COMMIT PREPARED

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: track_commit_timestamp and COMMIT PREPARED
Date: 2015-09-29 18:06:19
Message-ID: 20150929180619.GF2573@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Fujii, thanks for the review. I have pushed the patch to 9.5 and
master.

Fujii Masao wrote:

> @@ -5321,7 +5333,7 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
> /* Set the transaction commit timestamp and metadata */
> TransactionTreeSetCommitTsData(xid, parsed->nsubxacts, parsed->subxacts,
> commit_time, origin_id,
> - false);
> + false, true);
>
> Why does xact_redo_commit always set replaying_xlog and write_xlog to
> false and true, respectively? ISTM that they should be opposite...

A stupid oversight on my part. Thanks for pointing it out.

Thanks, Petr, for the patches.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeremy Harris 2015-09-29 18:20:38 Re: BRIN indexes for MAX, MIN, ORDER BY?
Previous Message Shulgin, Oleksandr 2015-09-29 17:52:46 Re: On-demand running query plans using auto_explain and signals