From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_resetxlog sentences |
Date: | 2015-09-16 20:00:19 |
Message-ID: | 20150916200019.GQ88970@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Robert Haas wrote:
> On Tue, Sep 15, 2015 at 9:52 PM, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
> > While updating translations, I came across those almost similar sentences.
> >
> > pg_controldata.c
> >
> > 273 printf(_("Latest checkpoint's oldestCommitTs: %u\n"),
> > 274 ControlFile.checkPointCopy.oldestCommitTs);
> >
> > pg_resetxlog.c
> >
> > 668 printf(_("Latest checkpoint's oldest CommitTs: %u\n"),
> > 669 ControlFile.checkPointCopy.oldestCommitTs);
> > 670 printf(_("Latest checkpoint's newest CommitTs: %u\n"),
> > 671 ControlFile.checkPointCopy.newestCommitTs);
> >
> > To be consistent, let's change pg_resetxlog to mimic pg_controldata
> > sentence. Patch is attached. It is new in 9.5 so backpatch is needed.
>
> Seems like a good idea to me. Anyone disagree?
OK with me.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2015-09-16 20:03:14 | Re: Reliance on undefined behaviour in << operator |
Previous Message | Tom Lane | 2015-09-16 19:57:04 | Re: Reliance on undefined behaviour in << operator |