From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: RLS refactoring |
Date: | 2015-09-15 22:16:55 |
Message-ID: | 20150915221655.GK88970@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Stephen Frost wrote:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > Stephen Frost <sfrost(at)snowman(dot)net> writes:
> >
> > It looks to me like this changed the representation of stored rules, so it
> > should have included a catversion bump. This is particularly relevant to
> > the 9.5 branch where people already have alpha installations.
>
> I had considererd if a bump was needed and figured it wasn't.
>
> The WithCheckOption node which was changed doesn't ever end up in the
> catalog, I don't believe; certainly not in pg_policy which just stores
> the expressions which come from transformWhereClause, which haven't
> changed.
Uhm, so why is it in readfuncs.c? If you create a view "WITH CHECK
OPTION", the pg_rewrite row says ":withCheckOptions <>". Does that not
change with your commit?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-09-15 22:19:54 | Re: pgsql: RLS refactoring |
Previous Message | Stephen Frost | 2015-09-15 22:00:02 | Re: pgsql: RLS refactoring |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-09-15 22:19:54 | Re: pgsql: RLS refactoring |
Previous Message | Stephen Frost | 2015-09-15 22:00:02 | Re: pgsql: RLS refactoring |