Re: snapshot too old, configured by time

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Kevin Grittner <kgrittn(at)ymail(dot)com>
Cc: Steve Singer <steve(at)ssinger(dot)info>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: snapshot too old, configured by time
Date: 2015-09-15 17:07:46
Message-ID: 20150915170746.GE88970@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kevin Grittner wrote:

> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

> > I would place it inside src/test/modules, so that buildfarm
> > runs it automatically; I'm not sure it will pick up things in
> > src/test.
>
> As it stands now, the test is getting run as part of `make
> check-world`, and it seems like src/test/modules is about testing
> separate executables, so I don't think it makes sense to move the
> tests -- but I could be convinced that I'm missing something.

It's not conceived just as a way to test separate executables; maybe it
is at the moment (though I don't think it is?) but if so that's just an
accident. The intention is to have modules that get tested without them
being installed, which wasn't the case when they were in contrib.

The problem with check-world is that buildfarm doesn't run it. We don't
want to set up separate buildfarm modules for each subdir in src/test;
that would be pretty tedious.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message YUriy Zhuravlev 2015-09-15 17:16:10 Re: Move PinBuffer and UnpinBuffer to atomics
Previous Message Michael Paquier 2015-09-15 16:59:26 Re: Small typo in timeline.h regarding the meaning of infinity for timeline history entry