From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
Cc: | Joe Conway <mail(at)joeconway(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: RLS open items are vague and unactionable |
Date: | 2015-09-15 14:22:34 |
Message-ID: | 20150915142234.GS3685@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dean,
* Dean Rasheed (dean(dot)a(dot)rasheed(at)gmail(dot)com) wrote:
> A minor point -- this comment isn't quite right:
Fixed.
> because the policies that are fetched there are only used for
> add_security_quals(), not for add_with_check_options(). It might be
> cleaner if the 'if' statement that follows were merged with the
> identical one a few lines down, and then those returning policies
> could be local to that block, with the 2 pieces of RETURNING handling
> done together. Similarly for the upsert block.
Done.
> Actually, it isn't necessary to test that rt_index ==
> root->resultRelation, because for all other relations commandType is
> set to CMD_SELECT higher up, so the 'returning' bool variable could
> just be replaced with 'root->returningList != NIL' throughout.
Done.
Updated patch attached for review.
Unless there are other concerns or issues raised, I'll push this later
today.
Thanks!
Stephen
Attachment | Content-Type | Size |
---|---|---|
rls-refactoring.v4.patch | text/x-diff | 55.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2015-09-15 14:24:14 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
Previous Message | Tom Lane | 2015-09-15 13:51:48 | Re: [COMMITTERS] pgsql: Fix an O(N^2) problem in foreign key references. |