From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Дмитрий Воронин <carriingfate92(at)yandex(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: New functions |
Date: | 2015-09-08 00:32:02 |
Message-ID: | 20150908003202.GZ2912@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Michael Paquier wrote:
> Note for committers: attached is a small script that will generate a
> client certificate with extensions enabled. This is helpful when
> testing this patch. Once created, then simply connect with something
> like this connection string:
> "host=127.0.0.1 sslmode=verify-full sslcert=client.crt
> sslkey=client.key sslrootcert=server.crt"
> By querying the new function implemented by this patch the information
> about the client certificate extensions will show up.
Thanks, this was useful.
I made a couple extra cleanups to the patch, namely: do not call
CreateTemplateTupleDesc() just to discard the resulting tupdesc with a
subsequent get_call_result_type(); and do not write a \0 to the
BIO_s_mem, and instead use BIO_get_mem_data's return value as length
when converting str to text *.
And pushed.
FWIW I now think I made a mistake with the error checks that I
backpatched, because the wording of the error messages I used "failed to
foo" is frowned upon by our message style guidelines. Should be "could
not do foo" instead.
Thanks,
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2015-09-08 00:32:28 | Re: [COMMITTERS] pgsql: contrib/sslinfo: add ssl_extension_info SRF |
Previous Message | Michael Paquier | 2015-09-08 00:29:22 | Re: [COMMITTERS] pgsql: contrib/sslinfo: add ssl_extension_info SRF |