| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: AcquireRewriteLocks/acquireLocksOnSubLinks vs. rowsecurity |
| Date: | 2015-08-28 12:53:34 |
| Message-ID: | 20150828125334.GB4857@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-08-28 08:49:24 -0400, Stephen Frost wrote:
>
> + /*
> + * get_row_security_policies just added to securityQuals and/or
> + * withCheckOptions, and there were SubLinks, so make sure
> + * we lock any relations which were added as a result.
> + */
Very minor comment: Strictly speaking the quals/wces haven't yet been
added to the Query, that happens only few lines down. I think it makes
sense to mention that we normally rely on the parser to acquire locks,
but that can't work here since sec quals/wces aren't visible to the
parser.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-08-28 13:03:22 | Re: AcquireRewriteLocks/acquireLocksOnSubLinks vs. rowsecurity |
| Previous Message | Stephen Frost | 2015-08-28 12:49:24 | Re: AcquireRewriteLocks/acquireLocksOnSubLinks vs. rowsecurity |