| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Subject: | Re: GinPageIs* don't actually return a boolean |
| Date: | 2015-08-12 22:54:02 |
| Message-ID: | 20150812225402.GA701@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-08-12 18:52:59 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > I went through all headers in src/include and checked for macros
> > containing [^&]&[^&] and checked whether they have this hazard. Found a
> > fair number.
>
> > That patch also changes !! tests into != 0 style.
>
> Looks OK to me, except I wonder why you did this
>
> #define TRIGGER_FIRED_FOR_ROW(event) \
> - ((event) & TRIGGER_EVENT_ROW)
> + (((event) & TRIGGER_EVENT_ROW) == TRIGGER_EVENT_ROW)
>
> rather than != 0. That way doesn't look either more efficient or
> more readable.
Purely consistency with the surrounding code. I was on the fence about
that one...
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-08-12 23:03:50 | Re: GinPageIs* don't actually return a boolean |
| Previous Message | Tom Lane | 2015-08-12 22:52:59 | Re: GinPageIs* don't actually return a boolean |