| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Warnings around booleans |
| Date: | 2015-08-12 19:45:28 |
| Message-ID: | 20150812194528.GA21836@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
I'm currently investigating some of our code cleanliness issues around
booleans. Turns out that ecpg fails if C99's _Bool is used as bool
instead of typedef char bool.
Playing around a bit lead to to find that this is caused by a wrong type
declaration in two places. 'isarray' is declared as bool instead of enum
ARRAY_TYPE in two places. This appears to be an oversight, perhaps
caused by the boolean sounding name.
Does this look right to you? If so, will you apply it?
- Andres
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ecpg-Use-ARRAY_TYPE-instead-of-a-bool-to-store-the-a.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2015-08-12 19:53:09 | Re: WIP: SCRAM authentication |
| Previous Message | Andrew Dunstan | 2015-08-12 19:18:02 | Re: pgsql: Further fixes for degenerate outer join clauses. |