| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net> |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-08-03 02:20:12 |
| Message-ID: | 20150803022012.GA1718925@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 03, 2015 at 01:32:10AM +0000, Kouhei Kaigai wrote:
> > On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> > > I observed these inconsistencies in node support functions:
> >
> > A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
> > INT/UINT or field order corrections. The non-cosmetic changes involve
> > CustomPath, CustomScan, and CreatePolicyStmt. Feature committers, if the
> > existing treatments (ignore custom_plans/custom_paths fields; copy/compare
> > "cmd" string pointer as a scalar) were deliberate, please let me know.
> >
> Thanks for your works.
>
> I also noticed one other inconsistent point; _outMergeJoin() dumps
> mergeNullsFirst[] array but it does not use booltostr() macro.
Good catch. All supported branches work that way, and it's not wrong. I
recommend keeping it unchanged.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-08-03 03:31:16 | Re: nodes/*funcs.c inconsistencies |
| Previous Message | Michael Paquier | 2015-08-03 02:15:58 | Re: Improving test coverage of extensions with pg_dump |