Re: pgsql: Add some test coverage of EvalPlanQual with non-locked tables.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add some test coverage of EvalPlanQual with non-locked tables.
Date: 2015-07-29 17:39:16
Message-ID: 20150729173916.GJ2441@postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Add some test coverage of EvalPlanQual with non-locked tables.
>
> A Salesforce colleague of mine griped that the regression tests don't
> exercise EvalPlanQualFetchRowMarks() and allied routines. Which is
> a fair complaint. Add test cases that go through the REFERENCE and COPY
> code paths. Unfortunately we don't have sufficient infrastructure right
> now to exercise the FDW code path in the isolation tests, but this is
> surely better than before.

FWIW the test_decoding module has isolation tests (pretty ugly
admittedly). I guess you could do something similar in the postgres_fdw
module.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-07-29 18:02:49 pgsql: Fix TAP tests with "make installcheck".
Previous Message Tom Lane 2015-07-29 17:37:39 Re: pgsql: Make TAP tests work on Windows.