Re: contribcheck and modulescheck of MSVC's vcregress.pl cannot work independently

From: Noah Misch <noah(at)leadboat(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, peter_e(at)gmx(dot)net
Subject: Re: contribcheck and modulescheck of MSVC's vcregress.pl cannot work independently
Date: 2015-07-25 21:50:03
Message-ID: 20150725215003.GD1452488@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Sun, Jul 12, 2015 at 05:50:42AM -0700, Michael Paquier wrote:
> On Sun, Jul 12, 2015 at 3:57 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Mon, Jul 06, 2015 at 11:53:58PM -0700, Michael Paquier wrote:
> > > Attached is a patch to revert to the pre-9.4 way of doing...
> >
> > This is a start. Study "git diff REL9_4_STABLE src/tools/msvc/
> > vcregress.pl"
> > after applying it. To give just one example of material left to revert, it
> > leaves two absolute-path "chdir" calls in a row.
> >
>
> Then the attached I guess addresses your concerns..

It did not; that version moved the project from 5% done to 15% done, perhaps.
I redeveloped it for several more hours last weekend and today, and I plan to
commit the attached stack of patches.

nm

Attachment Content-Type Size
install-msvc-skip-temp-v1.patch text/plain 1.8 KB
path-dedup-vcregress-v1.patch text/plain 916 bytes
revert-95-vcregress-v1.patch text/plain 5.8 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2015-07-26 14:13:41 Re: [HACKERS] Grouping Sets: Fix unrecognized node type bug
Previous Message Bakhtawar Ashiq 2015-07-25 05:26:27 installation error please help