Re: pgbench - allow backslash-continuations in custom scripts

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: coelho(at)cri(dot)ensmp(dot)fr
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, andres(at)anarazel(dot)de, hlinnaka(at)iki(dot)fi, josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgbench - allow backslash-continuations in custom scripts
Date: 2015-07-24 08:36:32
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi, all.

Attatched is the revised version of this patch.

The first patch is not changed from before.

The second is fixed a kind of bug.

Ths third is the new one to allow backslash continuation for
backslash commands.

hoge.sql is the test custom script.

At Fri, 24 Jul 2015 07:39:16 +0200 (CEST), Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote in <alpine(dot)DEB(dot)2(dot)10(dot)1507240731050(dot)12839(at)sto>
> > - backslash commands is handled as the same as before: multiline
> > is not allowed.
> Hmm... that is really the feature I wanted to add initially, too bad
> it is the dropped one:-)

Ouch. The story has been derailed somewhere.

Since SQL statments could be multilined without particluar
marker, we cannot implement multilined backslash commands in the
same way..

The attached revised patch allows backslash continuation for
backslash comands. I suppose this is the same as what you did in
behavior. But SQL statements are still can be continued as psql

I'm not satisfied by the design but I don't see another way..

> >
> > I don't have idea how to deal with the copy of psqlscan.[lh] from
> > psql. Currently they are simply the dead copies of those of psql.
> I think that there should be no copies, but it should use relative
> symbolic links so that the files are kept synchronized.

Yeah, I think so but symlinks could harm on git and Windows. The
another way would be make copies it from psql directory. They
live next door to each other.

> > - Modifying psqlscan in psql requires consideration on how it is
> > used in pgbench.
> Yep, that is one of the reason why I did not want to go this way, bar
> my natural lazyness.


Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Prepare-for-share-psqlscan-with-pgbench.patch text/x-patch 7.0 KB
0002-Make-use-of-psqlscan-in-pgbench.patch text/x-patch 71.4 KB
0003-Allow-backslash-continuation-for-backslash-commads.patch text/x-patch 6.7 KB
unknown_filename text/plain 191 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-07-24 09:25:52 Re: We need to support ForeignRecheck for late row locking, don't we?
Previous Message Ildus Kurbangaliev 2015-07-24 07:42:05 Re: RFC: replace pg_stat_activity.waiting with something more descriptive