Re: [HACKERS] object_classes array is broken, again

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jaimin Pan <jaimin(dot)pan(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] object_classes array is broken, again
Date: 2015-07-22 03:55:13
Message-ID: 20150722035513.GI5596@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Jaimin Pan wrote:
> Hi all,
>
> How about this patch. I believe it will never missing someone and be
> detected while compiling.

Hmm, yeah this looks like something that's worth considering going
forward. I can't think of any reason not to do this. Perhaps we can
write getObjectClass using this, too.

The new file has a wrong comment above the list, copy-pasted from
rmgrlist.h.

I've always wondered about unifying OCLASS with OBJECT, but that's
probably a completely independent topic.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message ziyu-v 2015-07-22 06:40:42 BUG #13512: insert/select bytea met memory alloc issue
Previous Message Jaimin Pan 2015-07-22 00:53:53 Re: [HACKERS] object_classes array is broken, again

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-07-22 03:57:17 Re: Alpha2/Beta1
Previous Message Noah Misch 2015-07-22 03:40:58 Re: Alpha2/Beta1