| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |
| Date: | 2015-07-20 09:46:47 |
| Message-ID: | 20150720094647.GX5520@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2015-07-17 21:40:45 +0300, Heikki Linnakangas wrote:
> Hmm, that function is pretty fragile, it will segfault on any AT_* type that
> it doesn't recognize. Thankfully you get that compiler warning, but we have
> added AT_* type codes before in minor releases.
For in-core code that is supposed to handle all cases I find it much
better to get a compiler warning than to error out in a default:
case. The latter is very likely not going to be exercised by any test
and thus not be noticed for prolonged time.
Might make sense to test for -Werror=switch and add that to the compiler
flags by default.
Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-07-20 09:52:10 | Re: pgsql: Add some comments to test_ddl_deparse and a README |
| Previous Message | Heikki Linnakangas | 2015-07-20 09:40:59 | Re: pgsql: Add some comments to test_ddl_deparse and a README |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2015-07-20 09:55:06 | Re: Implementation of global temporary tables? |
| Previous Message | Thakur, Sameer | 2015-07-20 09:32:41 | Re: [PROPOSAL] VACUUM Progress Checker. |