| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | David Christensen <david(at)endpoint(dot)com>, PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add checksums without --initdb |
| Date: | 2015-07-02 20:46:42 |
| Message-ID: | 20150702204642.GK16267@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015-07-02 23:43:17 +0300, Heikki Linnakangas wrote:
> >You'd need, afaics, a bgworker that connects to every database to read
> >pg_class, to figure out what type of page a relfilenode has. And this
> >probably should call back into the relevant AM or such.
>
> Nah, we already assume that every relation data file follows the standard
> page format, at least enough to have the checksum field at the right
> location. See FlushBuffer() - it just unconditionally calculates the
> checksum before writing out the page. (I'm not totally happy about that, but
> that ship has sailed)
Ugh, I'd forgotten about that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-07-02 20:56:16 | Re: PATCH:do not set Win32 server-side socket buffer size on windows 2012 |
| Previous Message | Heikki Linnakangas | 2015-07-02 20:43:17 | Re: Add checksums without --initdb |