Re: Incorrect processing of CREATE TRANSFORM with DDL deparding

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Incorrect processing of CREATE TRANSFORM with DDL deparding
Date: 2015-06-21 19:25:20
Message-ID: 20150621192520.GG133018@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Michael Paquier wrote:
> On Fri, Jun 5, 2015 at 6:24 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> >
> > Michael Paquier wrote:
> >
> > > And I actually bumped into a bug with this fake test case:
> > > DROP TRANSFORM FOR int LANGUAGE SQL;
> > > + ERROR: requested object address for unsupported object class 32: text
> > > result "unrecognized object 3576 16551 0"
> > > What happens is that the handling for transforms in getObjectIdentityParts
> > > is missing. This is fixed as well in the attached.
> >
> > Oh, interesting. We need one or two extra lines in the
> > object_address.sql test as well, I guess.
>
> Ah, so that's where it is... Attached is an updated patch with this
> stuff. I noticed a couple of code paths where OCLASS_TRANSFORM was
> missing as well.

Thanks, pushed that part of it. Looking at the event trigger bits next.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2015-06-21 22:34:49 Re: BUG #13455: Start fair
Previous Message Fabien COELHO 2015-06-20 07:04:19 Re: BUG #13442: ISBN doesn't always roundtrip with text