Re: Run pgindent now?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Run pgindent now?
Date: 2015-06-10 02:12:57
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Jun 9, 2015 at 09:56:13PM -0400, Robert Haas wrote:
> What I really don't want to do is apply the pgindent diff somewhat
> blindly, without really knowing how many cases we're improving and how
> many cases we're making worse. The number of times we've run pgindent
> and then realized later that it messed a bunch of stuff up is actually
> pretty high, and I find doing that to the back-branches particularly
> unexciting.

It is doing +1M lines of C code --- I assume it always will mess
something up.

Bruce Momjian <bruce(at)momjian(dot)us>

+ Everyone has their own god. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-06-10 02:28:35 Re: [patch] PL/Python is too lossy with floats
Previous Message Peter Eisentraut 2015-06-10 02:04:25 Re: [patch] PL/Python is too lossy with floats