Re: Run pgindent now?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Run pgindent now?
Date: 2015-05-25 23:41:07
Message-ID: 20150525234107.GO3908@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 26, 2015 at 01:15:17AM +0200, Andres Freund wrote:
> On 2015-05-25 19:01:28 -0400, Bruce Momjian wrote:
> > > A longer-term fix would be to make pgindent less stupid about this sort
> > > of usage, but nobody's yet volunteered to dig into the guts of that code.
> >
> > I assume a typedefs list is going to be a requirement of any decent C
> > indenting tool.
>
> Maybe I'm missing something major here, but why? Afaict it's just only
> used for formatting decisions that could be made without it just as well?

Uh, well, formatting decisions is what pgindent does. It is about
identifying variable declarations.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2015-05-26 00:18:37 Re: Update README.tuplock?
Previous Message Andres Freund 2015-05-25 23:15:17 Re: Run pgindent now?