Re: [PATCH] Generalized JSON output functions

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Generalized JSON output functions
Date: 2015-05-22 14:43:11
Message-ID: 20150522144311.GV5885@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan wrote:
>
> On 05/20/2015 09:16 AM, Shulgin, Oleksandr wrote:

> >Attached is a patch against master to generalize the JSON-producing
> >functions in utils/adt/json.c and to provide a set of callbacks which can
> >be overridden the same way that is already provided for *parsing* JSON.

> I'm not necessarily opposed to this, but it sure seems like a lot of
> changes, and moderately invasive ones, to support something that could be
> done, at the cost of reparsing, with a simple loadable extension that I
> could create in a few hours of programming.

But this seems like a pretty reasonable change to make, no? Doesn't the
total amount of code decrease after this patch? JSON stuff is pretty
new so some refactoring and generalization of what we have is to be
expected.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-22 14:50:53 Re: Missing importing option of postgres_fdw
Previous Message Uriy Zhuravlev 2015-05-22 14:02:44 Re: WIP: Enhanced ALTER OPERATOR