Re: best place for "rtree" strategy numbers

From: Alvaro Herrera <alvaro(dot)herrera(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: best place for "rtree" strategy numbers
Date: 2015-05-15 04:46:50
Message-ID: 20150515044650.GE2519@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:

> > I can, of course, just leave these files well enough alone and just rely
> > on the numbers not changing (which surely they won't anyway) and
> > remaining consistent with numbers used in new opclasses (which surely
> > they will lest they be born inconsistent with existing ones).
>
> Yeah, we do have checks in opr_sanity which will complain if inconsistent
> strategy numbers are used for similarly-named operators. That's a pretty
> weak test though, and operator names aren't exactly the right thing to
> check anyway. I'd be good with pushing all of that stuff to a new central
> header.

So here's a patch for this.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
stratnum.patch text/x-diff 15.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2015-05-15 05:03:35 Re: Providing catalog view to pg_hba.conf file - Patch submission
Previous Message Ashutosh Bapat 2015-05-15 04:41:38 Re: upper planner path-ification