Re: Final Patch for GROUPING SETS

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, Marti Raudsepp <marti(at)juffo(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Tomas Vondra <tv(at)fuzzy(dot)cz>, Atri Sharma <atri(dot)jiit(at)gmail(dot)com>, Svenne Krap <svenne(at)krap(dot)dk>
Subject: Re: Final Patch for GROUPING SETS
Date: 2015-05-14 17:18:11
Message-ID: 20150514171811.GI9584@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-05-14 09:16:10 +0100, Andrew Gierth wrote:
> Andres> A rough sketch of what I'm thinking of is:
>
> I'm not sure I'd do it quite like that.

It was meant as a sketch, so there's lots of things it's probably
missing ;)

> Rather, have a wrapper function get_outer_tuple that calls
> ExecProcNode and, if appropriate, writes the tuple to a tuplesort
> before returning it; use that in place of ExecProcNode in
> agg_retrieve_direct and when building the hash table.

Hm. I'd considered that, but thought it might end up being more complex
for hashing support. I'm not exactly sure why I thought that tho.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-14 17:38:49 Re: [COMMITTERS] pgsql: Add pg_audit, an auditing extension
Previous Message Jim Nasby 2015-05-14 17:12:49 Re: proposal: contrib module - generic command scheduler