Re: BUG #12730: pg_dump produces trailing spaces

On Tue, Apr 28, 2015 at 07:40:18PM -0400, Bruce Momjian wrote:
> > Try
> > pg_dump --format=p --schema=information_schema --schema-only --file=is.sql
> >
> > It seams there are trailing spaces in the comment line
> > -- Name: sql_implementation_info; Type: TABLE; Schema: information_schema;
> > Owner: postgres; Tablespace:
> >
> > Skip the string '; Tablespace: ' please, if there is no tablespace or put
> > '-' for the tablespace name in the same way as dash is used for Owner when
> > the option --no-owner is used.
>
> I looked into this issue and found that the pg_dump code doesn't handle
> cases where the reltablespace == 0 (default). I have modified pg_dump
> to test for a zero-length string as well, and this suppresses the
> "Tablespace:" field. Patch attached.

Patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +