| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: pg_upgrade: quote directory names in delete_old_cluster script |
| Date: | 2015-04-30 16:55:35 |
| Message-ID: | 20150430165535.GA32364@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Apr 29, 2015 at 11:59:26PM -0300, Alvaro Herrera wrote:
> Bruce Momjian wrote:
>
> > I have developed the attached patch to use platform-specific quoting of
> > path names.
>
> Part of me wonders about initdb's existing DIR_SEP and QUOTE_PATH
> definitions ... seems messy to reinvent these things all over again.
I don't think we can reuse QUOTE_PATH as it is used in initdb for
displaying potential ways of starting the server, and it assumes Unix
doesn't need quoting, while Windows usually does. For an actual script,
we always want to use quoting.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-04-30 17:01:06 | pgsql: Fix pg_upgrade's multixact handling (again) |
| Previous Message | Bruce Momjian | 2015-04-30 13:21:05 | Re: Re: pgsql: to_char(): have format 'OF' only show the leading negative sign |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2015-04-30 17:05:33 | ERROR: unexpected data beyond EOF |
| Previous Message | Robert Haas | 2015-04-30 16:55:27 | Re: feature freeze and beta schedule |