Re: why does enum_endpoint call GetTransactionSnapshot()?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: why does enum_endpoint call GetTransactionSnapshot()?
Date: 2015-04-29 01:28:54
Message-ID: 20150429012854.GI31727@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 14, 2015 at 05:29:43PM -0500, Robert Haas wrote:
> On Sat, Feb 14, 2015 at 5:12 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> I think this is probably a holdover from before the death of
> >> SnapshotNow, and that we should just pass NULL to
> >> systable_beginscan_ordered() here, the same as we do for other catalog
> >> accesses. Barring objections, I'll go make that change.
> >
> > Seems reasonable to me, but why are you only looking at that one and
> > not the identical code in enum_range_internal()?
>
> I noticed that one after hitting send. I think we should change them both.

Any news on this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Jones 2015-04-29 01:46:43 Re: Temporal extensions
Previous Message Jim Nasby 2015-04-29 00:36:30 Re: Feedback on getting rid of VACUUM FULL