| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com> |
| Subject: | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
| Date: | 2015-04-22 13:03:33 |
| Message-ID: | 20150422130333.GA20193@toroid.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2015-04-18 12:28:36 +0530, amit(dot)kapila16(at)gmail(dot)com wrote:
>
> I think you have missed to address the below point:
>
> >> 4) prefetch
Updated patch attached, as well as the diff against the earlier version
just to make it easier to see the exact change I made (which is to copy
the skip logic from lazy_scan_heap, as you suggested).
I'm not entirely convinced that this change is worthwhile, but it's easy
to make and difficult to argue against, so here it is. (I did test, and
it seems to work OK after the change.)
Amit, Tomas, thanks again for your review comments.
-- Abhijit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-20150422-Add-pgstatbloat-to-pgstattuple.patch | text/x-diff | 20.8 KB |
| inter.diff | text/x-diff | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2015-04-22 14:09:04 | Re: Row security violation error is misleading |
| Previous Message | Amit Kapila | 2015-04-22 12:48:00 | Re: Parallel Seq Scan |