Re: pg_upgrade in 9.5 broken for adminpack

On Fri, Apr 17, 2015 at 04:11:44PM +0900, Michael Paquier wrote:
> On Fri, Apr 17, 2015 at 3:29 PM, Jeff Janes wrote:
> > Of course after sending that it became obvious. The C function is not
> > getting called because the SQL function is marked as being strict, yet is
> > called with NULL arguments.
> >
> > Trivial patch attached to unset strict flag in pg_proc.h.
> >
> > But CATALOG_VERSION_NO probably needs another bump as well.
>
> This looks good to me. I have tested your fix and the problem goes
> away. create_empty_extension() was the only function not declared as
> STRICT before 30982be4 (see install_support_functions_in_new_db() in
> contrib/pg_upgrade/function.c).

OK, as I am not the author of that change, I am going to wait a little
while for the author to commit the fix. I can see it is an easy mistake
to make.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +