Re: pg_upgrade in 9.5 broken for adminpack

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade in 9.5 broken for adminpack
Date: 2015-04-17 02:37:56
Message-ID: 20150417023756.GB1868@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 16, 2015 at 07:33:50PM -0700, Jeff Janes wrote:
> pg_upgrade was recently broken for use upgrading from a system with adminpack
> installed.
>
> Breaking commit is:
>
> commit 30982be4e5019684e1772dd9170aaa53f5a8e894
> Author: Peter Eisentraut <peter_e(at)gmx(dot)net>
>
>     Integrate pg_upgrade_support module into backend
>
>
> from pg_upgrade_dump_12870.log
>
> pg_restore: creating EXTENSION "adminpack"
> pg_restore: creating COMMENT "EXTENSION "adminpack""
> pg_restore: [archiver (db)] Error while PROCESSING TOC:
> pg_restore: [archiver (db)] Error from TOC entry 2806; 0 0 COMMENT EXTENSION
> "adminpack"
> pg_restore: [archiver (db)] could not execute query: ERROR:  extension
> "adminpack" does not exist
>     Command was: COMMENT ON EXTENSION "adminpack" IS 'administrative functions
> for PostgreSQL';
>
>
> I get the same error whether the source database is 9.2.10 or 9.5.HEAD.

Uh, I am confused how moving pg_upgrade or pg_upgrade_support would
break the loading of the "adminpack" extension.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-04-17 02:41:12 Re: Supporting src/test/modules in MSVC builds
Previous Message Jeff Janes 2015-04-17 02:33:50 pg_upgrade in 9.5 broken for adminpack