show xl_prev in xlog.c errcontext

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: show xl_prev in xlog.c errcontext
Date: 2015-04-15 20:35:36
Message-ID: 20150415203536.GH4369@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I found this patch in my local repo that I wrote some weeks or months
ago while debugging some XLog corruption problem: it was difficult to
pinpoint what XLog record in a long sequence of WAL files was causing a
problem, and the displaying the prev pointer in errcontext made finding
it much easier -- I could correlate it with pg_xlogdump output, I think.

Anyone sees a reason not to apply this or something like it?

(As I recall, we eventually found out that the underlying issue was that
two postmasters shared one data area over NFS and were overwriting one
another's WAL files, or something like that. But this was some time ago
so I could be mistaken that it's the same case.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
errctx-prev.patch text/x-diff 688 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrzej Barszcz 2015-04-15 20:40:39 reparsing query
Previous Message Pavel Stehule 2015-04-15 20:11:43 Re: raw output from copy