Re: PATCH: Spinlock Documentation

On Sun, Apr 05, 2015 at 06:50:59PM +0000, Artem Luzyanin wrote:
> Hello, 
>
> I am new to PostgreSQLcommunity, but I would like to become a
> contributer eventually. I have readthrough your "Submitting Patch"
> guide and decided to follow "Start with submitting a patch that is
> small anduncontroversial to help them understand you, and to get you
> familiar with theoverall process" suggestion. 
>
> I am interested inplatform-specific spinlock implementation, so I
> looked at s_lock.h file for possibleimprovement. Since it took me
> some time to find possible areas of improvement,I would like to
> submit a small patch that would facilitate the process forfuture
> contributors (including myself). Since this is my first e-mail,
> pleaselet me know if I should have done something differently in
> order to submit apatch for the community.  

One issue with this patch is that it is not localized. If someone
goes and changes the S_LOCK implementation for one of the platforms
below, or adds a new platform, etc., without changing this comment
too, this comment becomes confusingly obsolete.

How do you plan to address this issue?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate