| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | jeff(dot)janes(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: vac truncation scan problems |
| Date: | 2015-04-02 16:39:43 |
| Message-ID: | 20150402163943.GA2969@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kyotaro HORIGUCHI wrote:
> Hi, this is a bug in the commit 0d831389749a3baaced7b984205b9894a82444b9 .
>
> It allows vucuum freeze to be skipped and inversely lets regular
> vacuum wait for lock. The attched patch fixes it.
>
>
> In table_recheck_autovac, vacuum options are determined as following,
>
> > tab->at_vacoptions = VACOPT_SKIPTOAST |
> > (dovacuum ? VACOPT_VACUUM : 0) |
> > (doanalyze ? VACOPT_ANALYZE : 0) |
> !> (wraparound ? VACOPT_NOWAIT : 0);
>
> The line prefixed by '!' looks inverted.
You're absolutely right. My mistake. Pushed your patch, thanks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-04-02 16:42:03 | Re: POLA violation with \c service= |
| Previous Message | Peter Geoghegan | 2015-04-02 16:14:45 | Re: Abbreviated keys for Numeric |