Re: authentication_timeout ineffective for replication connections

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: authentication_timeout ineffective for replication connections
Date: 2015-04-02 03:18:44
Message-ID: 20150402031844.GE29404@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 13, 2015 at 03:29:04PM +0100, Andres Freund wrote:
> Hi,
>
> I just noticed that authentication_timeout is ineffective for
> replication=true type connections. That's because walsender doesn't
> register a SIGINT handler and authentication_timeout relies on having
> one.
>
> There's no problem with reading the initial startup packet
> (ProcessStartupPacket/BackendInitialize) because we use a separate
> handler there. But once that's done, before finishing authentication,
> WalSndSignals() will have set SIGINT's handler to SIG_IGN.
>
> Demo python program attached. You'll only see the problem if the
> authentication method requires a password/addititional packets.
>
> I think we could fix this by simply mapping SIGINT to die() instead
> SIG_IGN.

What is the status on this?

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-04-02 04:53:11 Re: Additional role attributes && superuser review
Previous Message Stephen Frost 2015-04-02 03:14:59 Re: Relation extension scalability