From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__. |
Date: | 2015-03-26 13:19:55 |
Message-ID: | 20150326131955.GG451@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2015-03-25 19:11:06 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Add macros wrapping all usage of gcc's __attribute__.
>
> I noticed that this commit attached pg_attribute_noreturn not only
> to the extern declarations, but to some actual function definitions.
Unless either Oskari or I screwed up, it should just have been a 1:1
translation from previous __attribute__((noreturn)) to
pg_attribute_noreturn. I looked through the commit just now and didn't
see any new locations.
> I think this is a bad idea, because it's going to look like heck after
> pgindent gets through with it. Do we actually need decoration on the
> function definitions?
Hm, I guess it should not look any worse than before? None of the
locations look like they've been introduced after the last pgindent
run. I only see plpgsql_yyerror, yyerror. That said, I see little reason
to add the noreturn thingy to the definition and not the declaration for
those. It actually looks to me like there's a declaration for
replication_yyerror, but a plain yyerror is used instead in repl_scanner.l?
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2015-03-26 15:27:32 | Re: Re: [COMMITTERS] pgsql: Add macros wrapping all usage of gcc's __attribute__. |
Previous Message | Tom Lane | 2015-03-26 02:16:49 | Re: Re: [COMMITTERS] pgsql: btree_gin: properly call DirectFunctionCall1() |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2015-03-26 13:35:31 | Re: controlling psql's use of the pager a bit more |
Previous Message | Vladimir Borodin | 2015-03-26 07:19:07 | Re: pg_rewind in contrib |