| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: btree_gin and ranges |
| Date: | 2015-03-20 10:55:02 |
| Message-ID: | 20150320105502.GP3636@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Teodor Sigaev wrote:
> >Teodor's patch could use some more comments. The STOP_SCAN/MATCH_SCAN/CONT_SCAN
> >macros are a good idea, but they probably should go into
> >src/include/access/gin.h so that they can be used in all compare_partial
> >implementations.
>
> STOP_SCAN/MATCH_SCAN/CONT_SCAN macros are moved to gin's header, and
> comments are improved.
>
> Split patch to two: gin and module
Here you forgot to "git add" the two .sql files for the extension. They
are present in the patch Heikki posted upthread but not here.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Max Filippov | 2015-03-20 10:57:44 | Re: configure can't detect proper pthread flags |
| Previous Message | Amit Kapila | 2015-03-20 10:44:13 | Re: assessing parallel-safety |