| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree) |
| Date: | 2015-03-09 13:47:00 |
| Message-ID: | 20150309134700.GN3291@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> On Sun, Mar 1, 2015 at 2:38 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> > I'm going to mark this back to 'waiting on author' in case there's
> > something material that I've missed which you can clarify. I had
> > started this review thinking to help move it along but after re-reading
> > the thread and thinking about it for a bit, I came around to the other
> > side and therefore think it should probably be rejected. We certainly
> > appreciate the effort, of course.
>
> Re-reading this thread there are 3 perplexed opinions from three
> different committers, and nobody pleading in favor of this patch
> except me, so let's simply mark this as rejected and move on.
Well I also don't really like the existing behavior but it's not a big
issue and so I'm OK with letting go.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-03-09 14:02:46 | Re: pg_rewind in contrib |
| Previous Message | Tom Lane | 2015-03-09 13:46:08 | Re: Object files generated by ecpg test suite not ignored on Windows |