Re: deparsing utility commands

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: deparsing utility commands
Date: 2015-03-02 17:22:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2015-02-15 01:48:15 -0300, Alvaro Herrera wrote:
> This is a repost of the patch to add CREATE command deparsing support to
> event triggers. It now supports not only CREATE but also ALTER and
> other commands such as GRANT/REVOKE, COMMENT ON and SECURITY LABEL.
> This patch series is broken up in a rather large number of patches, but
> my intention would be to commit separately only the first 6 patches; the
> remaining parts are split up only so that it's easy to see how deparsing
> each patch is implemented, and would be committed as a single changeset
> (but before that I need a bunch of extra fixes and additions to other
> parts.)

I find the split of the patches not really helpful - it makes
fixing/cleaning up things unnecessarily complicated. I'd like most of
the individual command commits. Obviously the preparatory stuff that'll
be independely committed should stay separate. I also like that the
infrastructure patch is split of; same with the more wildly different
patches like support for GRANT.


Andres Freund

Andres Freund
PostgreSQL Development, 24x7 Support, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-03-02 17:23:56 Re: Merge compact/non compact commits, make aborts dynamically sized
Previous Message Andres Freund 2015-03-02 17:14:06 Re: Merge compact/non compact commits, make aborts dynamically sized