| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Simon Riggs <simon(at)2ndQuadrant(dot)com>, Yeb Havinga <yebhavinga(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, MauMau <maumau307(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com> |
| Subject: | Re: pgaudit - an auditing extension for PostgreSQL |
| Date: | 2015-02-18 14:28:49 |
| Message-ID: | 20150218142849.GB2500@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost wrote:
> Abhijit,
>
> * Abhijit Menon-Sen (ams(at)2ndQuadrant(dot)com) wrote:
> > I'm confused and unhappy about your characterisation of the state of
> > this patch. You make it seem as though there was broad consensus about
> > the changes that were needed, and that I left the patch sitting in the
> > archives for a long time without addressing important issues.
>
> The specific issue which I was referring to there was the #ifdef's for
> the deparse branch. I thought it was pretty clear, based on the
> feedback from multiple people, that all of that really needed to be
> taken out as we don't commit code to the main repo which has such
> external dependencies.
We can remove the #ifdef lines as soon as DDL deparse gets committed, of
course. There is no external dependency here, only a dependency on a
patch that's being submitted in parallel.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-02-18 14:41:46 | Re: Expanding the use of FLEXIBLE_ARRAY_MEMBER for declarations like foo[1] |
| Previous Message | Syed, Rahila | 2015-02-18 14:23:10 | Re: [REVIEW] Re: Compression of full-page-writes |