Re: TABLESAMPLE patch

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: petr(at)2ndquadrant(dot)com
Cc: amit(dot)kapila16(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, jaime(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, tv(at)fuzzy(dot)cz
Subject: Re: TABLESAMPLE patch
Date: 2015-01-28 07:23:31
Message-ID: 20150128.162331.13401375.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, I took a look on this and found nice.

By the way, the parameter for REPEATABLE seems allowing to be a
expression in ParseTableSample but the grammer rejects it.

The following change seems enough.

diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
index 4578b5e..8cf09d5 100644
--- a/src/backend/parser/gram.y
+++ b/src/backend/parser/gram.y
@@ -10590,7 +10590,7 @@ tablesample_clause:
;

opt_repeatable_clause:
- REPEATABLE '(' AexprConst ')' { $$ = (Node *) $3; }
+ REPEATABLE '(' a_expr ')' { $$ = (Node *) $3; }
| /*EMPTY*/ { $$ = NULL; }
;

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2015-01-28 07:28:15 Re: proposal: row_to_array function
Previous Message Pavel Stehule 2015-01-28 07:16:52 Re: proposal: row_to_array function