Re: moving from contrib to bin

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: moving from contrib to bin
Date: 2015-01-17 13:08:34
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2015-01-17 13:16:18 +0100, Andres Freund wrote:
> I'd also like to see patches that primarily move code around as git diff
> -M -C style diffs (can also be passed to format-patch). That will show
> the file move and then additionally the changes that have been made in
> addition to the rename. There's no sane way the current diffs can be
> reviewed without applying them to a tree.

Btw, this also avoids many trivial kind of conflicts... Which renames
generally are very prone to.

Rebased (fair amount of trivial conflicts due to the copyright year
bump) and attached as -MC style format-patch. If you look at the content
of the patches you can see that the diff makes more sense now.

1) Are we sure it's a good idea to rely on in src/bin programs?
2) I removed a stray 'port.c' and some whitespace as a fixup commit (git
rebase --autosquash ...) from the pg_upgrade_support commit
3) pg_upgrade tests didn't run due to a /src/ to much in the path to
4) I have doubts that it's ok to integrate the tests in src/bin just the
way they were done in contrib.
5) Doing the msvc support for all intermediate commits in a separate
commit strikes me as a bad idea. Essentially that makes the split
pretty pointless.
6) Similarly I'd much rather see the doc movement in the same commit as
the actually moved utility. Then we can start applying this one by one
on whatever we have agreement.
7) Are we sure that the authors in the affected contrib modules are ok
with their authorship notice being removed? I don't think Ants, Bruce
or Simon have a problem with that, but ...
8) Why did you remove Peter as the git author?

I've also pushed the git tree of these changes to;a=summary
branch move-contrib-bins-to-bin


Andres Freund

Andres Freund
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Sort-SUBDIRS-variable-in-src-bin-Makefile.patch text/x-patch 920 bytes
0002-Move-pg_archivecleanup-from-contrib-to-src-bin.patch text/x-patch 4.2 KB
0003-Move-pg_standby-from-contrib-to-src-bin.patch text/x-patch 3.7 KB
0004-Move-pg_xlogdump-from-contrib-to-src-bin.patch text/x-patch 5.7 KB
0005-Move-pgbench-from-contrib-to-src-bin.patch text/x-patch 3.5 KB
0006-Move-pg_test_fsync-from-contrib-to-src-bin.patch text/x-patch 3.7 KB
0007-Move-pg_test_timing-from-contrib-to-src-bin.patch text/x-patch 3.7 KB
0008-Integrate-pg_upgrade_support-module-into-backend.patch text/x-patch 26.6 KB
0009-Move-pg_upgrade-from-contrib-to-src-bin.patch text/x-patch 16.1 KB
0010-Add-MSVC-support-for-new-modules-in-src-bin.patch text/x-patch 10.2 KB
0011-Move-documentation-of-new-src-bin-utilities-to-ref.patch text/x-patch 7.9 KB
0012-fixup-Integrate-pg_upgrade_support-module-into-backe.patch text/x-patch 2.3 KB
0013-fixup-Move-pg_upgrade-from-contrib-to-src-bin.patch text/x-patch 775 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-01-17 14:06:40 Re: Safe memory allocation functions
Previous Message Amit Kapila 2015-01-17 12:46:24 Re: TABLESAMPLE patch